feat: add [marimo.server.disable_file_downloads] #7844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@AnirudhDagar thanks for making this PR. there are a few other places its possible to download files. and this may still be possible through the APIs, etc. this feature may attract more bug and followup FRs that we might not be able to handle at the moment |
Contributor
Author
|
@mscolnick If you could point me to the other places where we'd want to block the downloads when the flag is on, I'd be happy to take a look and update the PR. But if this is a feature that we don't want to add yet due to bandwidth, I can close the PR? |
mscolnick
changed the title
mscolnick
reviewed
Jan 15, 2026
mscolnick
reviewed
Jan 15, 2026
Contributor
|
@AnirudhDagar i was wrong, i thought we had a specific endpoint to download (instead we just read it on the frontend and then download it). we can finish off this PR. i left some comments. also we don't need a CLI flag for this to reduce the API surface area (and can just pick this up from user config) |
manzt
reviewed
Jan 15, 2026
Contributor
manzt
left a comment
manzt
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I agree with regard to adding the flag to the CLI to avoid increasing API surface.
manzt
previously approved these changes
Jan 15, 2026
manzt
reviewed
Jan 15, 2026
Contributor
manzt
left a comment
manzt
left a comment
There was a problem hiding this comment.
sorry, meant to comment not yet approve!
Contributor
Author
|
Thanks @mscolnick @manzt for sharing your thoughts, I've removed the CLI flag and added the option to change the config in case needed. |
mscolnick
changed the title
Contributor
|
@AnirudhDagar can you run |
Contributor
Author
|
Thanks @mscolnick, I've pushed the changes. Forgot to run it after the doc updates. |
mscolnick
reviewed
Jan 16, 2026
mscolnick
approved these changes
Jan 16, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.5-dev9 |
botterYosuke
pushed a commit
to botterYosuke/marimo
that referenced
this pull request
Jan 17, 2026
## 📝 Summary Fix marimo-team#7830 ## 🔍 Description of Changes Adds a new config flag `[marimo.server.disable_file_downloads]` that hides the file download button in the file explorer and viewer toolbar. Usage: ```bash [tool.marimo.server] disable_file_downloads = True ``` When enabled, the download button is hidden in: * File explorer context menu (screenshot 1) * File viewer toolbar (screenshot 2) Screenshots <table> <tr><th colspan="2">File Explorer Context Menu</th></tr> <tr><td><strong>Before</strong></td><td><strong>After</strong></td></tr> <tr> <td><img width="300" alt="before" src="https://github.com/user-attachments/assets/fcb7edbc-88d9-40ff-b7e9-1b235396d6c9" /></td> <td><img width="300" alt="after" src="https://github.com/user-attachments/assets/08c104ed-7557-43d0-aad5-088daa6a1563" /></td> </tr> <tr><th colspan="2">File Viewer Toolbar</th></tr> <tr><td><strong>Before</strong></td><td><strong>After</strong></td></tr> <tr> <td><img width="300" alt="before" src="https://github.com/user-attachments/assets/208e5973-13a9-4cf1-b7ba-3834f285454d" /></td> <td><img width="300" alt="after" src="https://github.com/user-attachments/assets/07523df6-cdca-410c-bca1-dd3c8ece3960" /></td> </tr> </table> ps. I was not sure if we need this flag for all run/tutorial/new/edit, so I added it for consistency but I can change that based on the review. ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [x] Tests have been added for the changes made. - [x] Documentation has been updated where applicable, including docstrings for API changes. - [x] Pull request title is a good summary of the changes - it will be used in the [release notes](https://github.com/marimo-team/marimo/releases). --------- Co-authored-by: Myles Scolnick <myles@marimo.io>
mscolnick
added a commit
that referenced
this pull request
Jan 19, 2026
## 📝 Summary Fix #7830 ## 🔍 Description of Changes Adds a new config flag `[marimo.server.disable_file_downloads]` that hides the file download button in the file explorer and viewer toolbar. Usage: ```bash [tool.marimo.server] disable_file_downloads = True ``` When enabled, the download button is hidden in: * File explorer context menu (screenshot 1) * File viewer toolbar (screenshot 2) Screenshots <table> <tr><th colspan="2">File Explorer Context Menu</th></tr> <tr><td><strong>Before</strong></td><td><strong>After</strong></td></tr> <tr> <td><img width="300" alt="before" src="https://github.com/user-attachments/assets/fcb7edbc-88d9-40ff-b7e9-1b235396d6c9" /></td> <td><img width="300" alt="after" src="https://github.com/user-attachments/assets/08c104ed-7557-43d0-aad5-088daa6a1563" /></td> </tr> <tr><th colspan="2">File Viewer Toolbar</th></tr> <tr><td><strong>Before</strong></td><td><strong>After</strong></td></tr> <tr> <td><img width="300" alt="before" src="https://github.com/user-attachments/assets/208e5973-13a9-4cf1-b7ba-3834f285454d" /></td> <td><img width="300" alt="after" src="https://github.com/user-attachments/assets/07523df6-cdca-410c-bca1-dd3c8ece3960" /></td> </tr> </table> ps. I was not sure if we need this flag for all run/tutorial/new/edit, so I added it for consistency but I can change that based on the review. ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [x] Tests have been added for the changes made. - [x] Documentation has been updated where applicable, including docstrings for API changes. - [x] Pull request title is a good summary of the changes - it will be used in the [release notes](https://github.com/marimo-team/marimo/releases). --------- Co-authored-by: Myles Scolnick <myles@marimo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fix #7830
🔍 Description of Changes
Adds a new config flag
[marimo.server.disable_file_downloads]that hides the file download button in the file explorer and viewer toolbar.Usage:
When enabled, the download button is hidden in:
Screenshots
ps. I was not sure if we need this flag for all run/tutorial/new/edit, so I added it for consistency but I can change that based on the review.
📋 Checklist