fix: plotly shapes not clearing when removed from figure #7974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When shapes were added to a Plotly figure and then removed, they would persist visually even though the figure data no longer contained them. The fix changes the layout update logic to only preserve user-interaction values (dragmode, xaxis, yaxis) from the previous layout, while taking everything else from the new figure. Also refactored the layout management into a separate `usePlotlyLayout` hook with pure utility functions, enabling unit testing without rendering. Closes #7964
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Light2Dark
previously approved these changes
Jan 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Plotly rendering bug where shapes could remain visible after being removed from the figure by changing how layout state is preserved across figure updates.
Changes:
- Adjust layout update behavior to only persist user-interaction layout fields (dragmode/xaxis/yaxis) when the figure prop changes.
- Refactor Plotly layout management into a dedicated
usePlotlyLayouthook with pure helper functions. - Add unit tests and a Plotly smoke test reproducer for the shapes-clearing scenario.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| marimo/_smoke_tests/plotly/shapes.py | Adds a smoke-test reproducer for adding/removing Plotly shapes. |
| frontend/src/plugins/impl/plotly/usePlotlyLayout.ts | Introduces a new hook + utilities to manage layout preservation across figure updates. |
| frontend/src/plugins/impl/plotly/tests/usePlotlyLayout.test.ts | Adds unit coverage for the new layout utilities (including #7964 scenario). |
| frontend/src/plugins/impl/plotly/PlotlyPlugin.tsx | Integrates the new hook and updates reset behavior to clear persisted plugin state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Light2Dark
approved these changes
Jan 26, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.19.7-dev7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When shapes were added to a Plotly figure and then removed, they would persist visually even though the figure data no longer contained them.
The fix changes the layout update logic to only preserve user-interaction values (dragmode, xaxis, yaxis) from the previous layout, while taking everything else from the new figure.
Also refactored the layout management into a separate
usePlotlyLayouthook with pure utility functions, enabling unit testing without rendering.Closes #7964