fix(ui): slider editable input ignores debounce bug (#8677)#8682
Merged
Light2Dark merged 4 commits intomarimo-team:mainfrom Mar 19, 2026
Merged
fix(ui): slider editable input ignores debounce bug (#8677)#8682Light2Dark merged 4 commits intomarimo-team:mainfrom
Light2Dark merged 4 commits intomarimo-team:mainfrom
Conversation
When and are set on a slider, editing the numeric input does not trigger cell execution. This fixes the issue by forcing the NumberField's onChange to immediately setValue regardless of if the parent slider is configured with debounce, since numeric input edit events are explicitly requested by the user. Fixes marimo-team#8677
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the contribution rules and verified that all requirements are met: frontend linting and typechecks passed, UI tests were added, and all tests run successfully. I have read the CLA Document and I hereby sign the CLA |
for more information, see https://pre-commit.ci
Contributor
Author
|
recheck |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
Light2Dark
requested changes
Mar 14, 2026
Comment on lines
+11
to
+15
| class ResizeObserver { | ||
| observe() {} | ||
| unobserve() {} | ||
| disconnect() {} | ||
| } |
Collaborator
There was a problem hiding this comment.
recently we have used SetupMocks.resizeObserver(). Can we do the same here.
Contributor
Author
|
test: use SetupMocks for ResizeObserver in SliderPlugin test
|
Replaces the manual ResizeObserver mock with SetupMocks.resizeObserver() to align with repo conventions. Fixes minor typing issues in the createProps setup for the slider plugins test. Adds missing expect assertion to fix vitest/expect-expect eslint warning.
for more information, see https://pre-commit.ci
Light2Dark
approved these changes
Mar 19, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.21.2-dev13 |
axsseldz
pushed a commit
to axsseldz/marimo
that referenced
this pull request
Mar 19, 2026
marimo-team#8682) When `debounce=True` and `include_input=True` are set on a slider, editing the numeric input does not trigger cell execution. This fixes the issue by forcing the NumberField's onChange to immediately setValue regardless of if the parent slider is configured with debounce, since numeric input edit events are explicitly requested by the user. Fixes marimo-team#8677 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
debounce=Trueandinclude_input=Trueare set on a slider, editing the numeric input does not trigger cell execution. This fixes the issue by forcing the NumberField's onChange to immediately setValue regardless of if the parent slider is configured with debounce, since numeric input edit events are explicitly requested by the user.Fixes #8677