Skip to content

fix: markdown bullets inside of details#8767

Merged
mscolnick merged 1 commit intomainfrom
ms/fix-markdown-bullets-inside-of-details
Mar 19, 2026
Merged

fix: markdown bullets inside of details#8767
mscolnick merged 1 commit intomainfrom
ms/fix-markdown-bullets-inside-of-details

Conversation

@mscolnick
Copy link
Copy Markdown
Contributor

@mscolnick mscolnick commented Mar 18, 2026

Closes #8736

fix markdown bullets inside of details

Screenshot 2026-03-18 at 4 45 25 PM

Copilot AI review requested due to automatic review settings March 18, 2026 20:45
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Mar 18, 2026 8:46pm

Request Review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a Markdown rendering issue where unordered/ordered list markers inside /// details blocks don’t display with correct indentation in the frontend Markdown styling, and adds a smoke-test case to prevent regressions.

Changes:

  • Add a Markdown smoke-test example containing both bulleted and numbered lists inside a details block.
  • Update frontend Markdown CSS to restore list indentation for ul/ol directly inside details blocks.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
marimo/_smoke_tests/markdown/markdown_pymdownx.py Adds a details example with ul and ol content to exercise list rendering in collapsible blocks.
frontend/src/css/md.css Restores ul/ol padding inside .markdown details to prevent the p-4 rule from collapsing list marker space.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mscolnick mscolnick added the bug Something isn't working label Mar 18, 2026
@mscolnick mscolnick merged commit eb9f82d into main Mar 19, 2026
50 of 53 checks passed
@mscolnick mscolnick deleted the ms/fix-markdown-bullets-inside-of-details branch March 19, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrete bullets rendering (markeddown)

3 participants