Document stale globals caveat on ctx.globals#8802
Merged
Conversation
When code mode is used from the scratchpad, `run_cell` updates the kernel's globals but not the scratchpad's shallow copy. This means bare variable names read stale values. The docstring now directs callers to use `ctx.globals["x"]` instead.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
approved these changes
Mar 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ctx.globals docstring to document a scratchpad-specific caveat in code mode: run_cell updates the kernel’s globals, but bare variable names in the scratchpad may still reflect a stale shallow copy, so callers should read values via ctx.globals["x"].
Changes:
- Expand
globalsproperty docstring to explain stale scratchpad globals behavior afterrun_cell - Add guidance to prefer
ctx.globals["x"]over bare variable names when reading updated values
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.21.2-dev23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When code mode is used from the scratchpad,
run_cellupdates the kernel's globals but not the scratchpad's shallow copy. This means bare variable names read stale values. The docstring now directs callers to usectx.globals["x"]instead.