fix: file descriptor conflicts in terminal ws#8896
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses PTY file-descriptor lifecycle conflicts in the terminal WebSocket endpoint by avoiding os.fdopen() wrappers that can implicitly close shared descriptors, and slightly delays Renovate updates.
Changes:
- Replace
os.fdopen(...)/file.write()withos.read()/os.write()for the shared PTY master fd in terminal WS read/write loops. - Update Renovate’s
minimumReleaseAgefrom 3 days to 7 days.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
marimo/_server/api/endpoints/terminal.py |
Avoids double-close behavior by removing per-task fdopen() context managers around the shared PTY fd. |
.github/renovate.json5 |
Increases Renovate minimum release age to reduce update churn. |
select.select() has a FD_SETSIZE limitation where file descriptors must be < 1024, causing ValueError on Python 3.14 CI when many FDs are open. The selectors module uses epoll/kqueue and has no such limitation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.