Remove auto-instantiate from /api/execute endpoint#8943
Merged
Conversation
Code mode now builds its execution plan from the NotebookDocument and calls mutate_graph/_run_cells on the kernel directly, so the notebook no longer needs to be pre-instantiated before scratchpad execution. The _apply_ops diff source also switches from the graph to the document to stay consistent with this approach.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the implicit notebook instantiation that previously occurred inside the hidden /api/kernel/execute (SSE scratchpad) endpoint, aligning scratchpad execution with the newer “build execution plan from NotebookDocument” approach described in the PR metadata.
Changes:
- Removed the automatic
session.instantiate(..., auto_run=True)call from/api/kernel/execute, so the endpoint no longer guarantees the notebook has been instantiated before scratchpad execution.
mscolnick
approved these changes
Mar 31, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.21.2-dev102 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code mode now builds its execution plan from the NotebookDocument and calls mutate_graph/_run_cells on the kernel directly, so the notebook no longer needs to be pre-instantiated before scratchpad execution. The _apply_ops diff source also switches from the graph to the document to stay consistent with this approach.