ensure new connection for each test sql#9356
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DuckDB SQL error-handling tests to ensure each test runs against its own in-memory DuckDB connection, preventing cross-test table leakage and improving test isolation (superseding #9352’s table-cleanup approach).
Changes:
- Add a per-test
duckdb_connfixture that creates/closes an isolated in-memory DuckDB connection. - Update DuckDB-related tests to use
engine=duckdb_conn(andduckdb_conn.sql(...)) instead of the process-wide default connection.
akshayka
approved these changes
Apr 24, 2026
Contributor
akshayka
left a comment
There was a problem hiding this comment.
Thank you, much nicer :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Supersedes #9352 by ensuring each test runs in a duckdb connection that closes automatically.
📋 Pre-Review Checklist
✅ Merge Checklist
Summary by cubic
Use a fresh in-memory
duckdbconnection per test to isolate state and prevent flaky SQL error-handling tests. Tests now passengine=duckdb_connand callduckdb_conn.sql(...), so connections close automatically after each test.pytestfixtureduckdb_connthat createsduckdb.connect(':memory:')and closes it after each test.duckdb.sql(...)with explicitengine=duckdb_connandduckdb_conn.sql(...).Written for commit 359e017. Summary will update on new commits.