feat(minimap): show cell index in dependency minimap#9633
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a visible per-cell index to the dependency minimap list, adjusting layout offsets so the new index gutter doesn’t overlap existing content.
Changes:
- Extend
MinimapCellprops to accept anindexand render it as an absolute-positioned badge. - Adjust left padding and SVG positioning to account for the added index gutter.
- Pass the mapped index from
MinimapContentintoMinimapCell.
| <MinimapCell cellId={cellId} cellPositions={cellPositions} /> | ||
| <MinimapCell | ||
| cellId={cellId} | ||
| index={idx} |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Architecture diagram
sequenceDiagram
participant MM as MinimapContent
participant MC as MinimapCell
participant CG as Cell Graph
Note over MM,CG: Cell Index Display in Dependency Minimap
MM->>MM: Map ordered cell list
loop For each cell (idx, cellId)
MM->>MC: Render MinimapCell(cellId, index=idx, cellPositions)
MC->>MC: Render cell row with left padding [59px]
MC->>MC: Render index span (absolute, left:0, 5px wide)
Note over MC: Shows cell index number<br/>(e.g., "1", "2", "3")
MC->>CG: Use cellId for dependency graph
CG-->>MC: Cell state, connections
MC->>MC: Render cell preview text
MC->>MC: Render SVG dependency edges<br/>(left offset adjusted to 25px)
end
Bundle ReportChanges will increase total bundle size by 11.44kB (0.05%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: marimo-esmAssets Changed:
Files in
|
kirangadhave
approved these changes
May 20, 2026
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.7-dev66 |
Collaborator
|
This looks really clean. I assume we have some kind of alignment when there are double/triple digit cells? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
show cell index in dependency minimap