Add padding between cell number and minimap dependency lines#9675
Merged
Conversation
In the dependency-graph minimap, the upstream whisker on a selected cell extended to within ~2px of the cell-number label's container, making the line visually collide with the number when a cell was selected. Shift the dependency-dot SVG and the variable list 6px to the right so the whisker has breathing room against the label.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the dependency-graph minimap layout so the selected-cell upstream “whisker” no longer visually collides with the cell-number label area, improving readability of the minimap UI.
Changes:
- Increased left padding of each minimap row to move the variable/preview text rightward.
- Shifted the dependency-dot SVG’s absolute
leftoffset rightward to match the new gutter.
Comment on lines
69
to
72
| "group bg-transparent text-left w-full flex relative justify-between items-center", | ||
| "border-none rounded cursor-pointer", | ||
| "h-[21px] pl-[59px] font-inherit", | ||
| "h-[21px] pl-[65px] font-inherit", | ||
| isSelected |
Comment on lines
108
to
111
| className={cn( | ||
| "absolute overflow-visible top-[10.5px] left-[calc(var(--spacing-extra-small,8px)+25px)] pointer-events-none", | ||
| "absolute overflow-visible top-[10.5px] left-[calc(var(--spacing-extra-small,8px)+31px)] pointer-events-none", | ||
| isSelected ? "z-[1]" : "z-0", | ||
| getTextColor({ cell, selectedCell }), |
Light2Dark
approved these changes
May 25, 2026
Collaborator
Light2Dark
left a comment
Light2Dark
left a comment
There was a problem hiding this comment.
I don't really notice any issue with the original styles but deferring to you if there is
Contributor
Author
|
Thanks, for some configurations (when there is an ancestor and descendant) the line overlaps the number (Trevor reported the issue) |
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.9-dev3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the dependency-graph minimap, the upstream whisker on a selected cell extended to within ~2px of the cell-number label's container, making the line visually collide with the number when a cell was selected.
This change shifts the dependency-dot SVG and the variable list 6px to the right so the whisker has breathing room against the label.