Skip to content

fix(e2e): assert the hero CTA by its real role (unbreaks CI on main) #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marinom2 merged 1 commit into from
Jul 29, 2026
Merged

fix(e2e): assert the hero CTA by its real role (unbreaks CI on main) #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/e2e/smoke.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ test("landing renders the dual-track hero and CTAs", async ({ page }) => {
await page.goto("/");
await expect(page.getByRole("heading", { name: /Build with, and run for/i })).toBeVisible();
await expect(page.getByRole("link", { name: /Builder hub/i }).first()).toBeVisible(); // build track CTA
await expect(page.getByRole("button", { name: /Get the app/i })).toBeVisible(); // worker track CTA
// Both CTAs are <Button asChild><Link>…</Link></Button>. asChild swaps the
// <button> for a Radix Slot that renders the child, so the DOM node is an <a>
// and the accessible role is "link", not "button" - assert what ships, not
// the component name that wraps it.
await expect(page.getByRole("link", { name: /Get the app/i })).toBeVisible(); // worker track CTA
});

test("nav: connect button + network toggle present", async ({ page }) => {
Expand Down
Loading