fix: Do not panic when reading malformed properties #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: I was trying to run the command:
mcphost -m google:gemini-2.5-prowith this
~/.mcp.jsonfile:{ "mcpServers": { "desktop-commander": { "command": "npx", "args": [ "-y", "@smithery/cli@latest", "run", "@wonderwhy-er/desktop-commander" ] } } }and set my GOOGLE_API_KEY appropriately.
mcphoststarted properly and the/toolsand/serverscommands worked fine.However, when I typed in "How many ebooks are in my Downloads folder?" it would panic within the
propertyToGoogleSchemamethod because when "name" was"value", the resulting map was empty (although thepropertyToGoogleSchemamethod assumes that the "type" key exists.This PR fixes the panic on malformed
schema.Properties.