Skip to content

Conversation

@gmlewis
Copy link
Contributor

@gmlewis gmlewis commented Apr 18, 2025

Background: I was trying to run the command:

  • mcphost -m google:gemini-2.5-pro

with this ~/.mcp.json file:

{
  "mcpServers": {
    "desktop-commander": {
      "command": "npx",
      "args": [
        "-y",
        "@smithery/cli@latest",
        "run",
        "@wonderwhy-er/desktop-commander"
      ]
    }
  }
}

and set my GOOGLE_API_KEY appropriately.

mcphost started properly and the /tools and /servers commands worked fine.
However, when I typed in "How many ebooks are in my Downloads folder?" it would panic within the propertyToGoogleSchema method because when "name" was "value", the resulting map was empty (although the propertyToGoogleSchema method assumes that the "type" key exists.

This PR fixes the panic on malformed schema.Properties.

gmlewis added 2 commits April 18, 2025 15:47
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@ezynda3 ezynda3 merged commit 4facfd6 into mark3labs:main Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants