Skip to content

fix: Do not panic when reading malformed properties #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

fix: Do not panic when reading malformed properties #31

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54703d4
fix: Do not panic when reading malformed properties
gmlewis Apr 18, 2025
070cfa6
Add one more check
gmlewis Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions pkg/llm/google/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,11 @@ func translateToGoogleSchema(schema llm.Schema) *genai.Schema {
}

for name, prop := range schema.Properties {
s.Properties[name] = propertyToGoogleSchema(prop.(map[string]any))
m, ok := prop.(map[string]any)
if !ok || len(m) == 0 {
continue
}
s.Properties[name] = propertyToGoogleSchema(m)
}

if len(s.Properties) == 0 {
Expand All @@ -142,7 +146,11 @@ func translateToGoogleSchema(schema llm.Schema) *genai.Schema {
}

func propertyToGoogleSchema(properties map[string]any) *genai.Schema {
s := &genai.Schema{Type: toType(properties["type"].(string))}
typ, ok := properties["type"].(string)
if !ok {
return nil
}
s := &genai.Schema{Type: toType(typ)}
if desc, ok := properties["description"].(string); ok {
s.Description = desc
}
Expand Down