Add ".exe" to windows executable path if it is not explicitly set#4
Merged
markbates merged 1 commit intomarkbates:masterfrom Jan 24, 2017
marpaia:buffalo-169
Merged
Add ".exe" to windows executable path if it is not explicitly set#4markbates merged 1 commit intomarkbates:masterfrom marpaia:buffalo-169
markbates merged 1 commit intomarkbates:masterfrom
marpaia:buffalo-169
Conversation
Owner
|
Thanks!! |
nathany
reviewed
Jan 24, 2017
|
|
||
| func (c *Configuration) FullBuildPath() string { | ||
| return path.Join(c.BuildPath, c.BinaryName) | ||
| path := path.Join(c.BuildPath, c.BinaryName) |
Collaborator
There was a problem hiding this comment.
path may not be the best variable name, given the use of the path package as well (a bit ambiguous)
Contributor
Author
There was a problem hiding this comment.
ah, yeah, this is a really good call. I can submit another PR to resolve this?
| return path.Join(c.BuildPath, c.BinaryName) | ||
| path := path.Join(c.BuildPath, c.BinaryName) | ||
| if runtime.GOOS == "windows" { | ||
| if !strings.HasSuffix(path, ".exe") { |
Collaborator
There was a problem hiding this comment.
this may not be a big issue, but do note that HasSuffix is case sensitive (e.g. resulting in app.EXE.exe)
Contributor
Author
There was a problem hiding this comment.
I can submit a new PR to lower the string first.
Owner
There was a problem hiding this comment.
If you open a pr to handle the case and change the path variable to something else would be great.
Collaborator
|
Whoops, looks like I'm too late to the party. That @markbates is fast! ;-) |
markbates
added a commit
that referenced
this pull request
Jan 24, 2017
Addressing review comments from #4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for gobuffalo/buffalo#169.