Fixed bug in _findBackgrounds() which caused to ignore elements with dat... - #25
Merged
markdalgleish merged 1 commit intoFeb 5, 2013
Conversation
…data-stellar-background if you pass them directly to stellar() function. Also replaced check for data property via "is([data-prop])" with "data('prop')".
markdalgleish
added a commit
that referenced
this pull request
Feb 5, 2013
Fixed bug in _findBackgrounds() which caused to ignore elements with dat...
Owner
|
Nice pickup, thanks for the pull request :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...a-stellar-background if you pass them directly to stellar() function. Also replaced check for data property via "is([data-prop])" with "data('prop')".
$stuff.add() doesn't change $stuff, so $backgroundElements remains unchanged
http://api.jquery.com/add/
I think check with "data('something')" is more appropriate than "is([data-something])"
Thank you for such a nice library! 👍