Update dependencies for site#129
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
|
|
|
Still to do:
|
Environment variables only apply to the production environment. In the Vercel dashboard, I've applied the Algolia and font CDN environment variables to preproduction environments, as well. The fonts still don't work because the Stripe CDN has a restrictive set of allowed hostnames, but the generated site output points to the correct domain and will work when deployed to |
0b1a4d7 to
618e55a
Compare
GIT_VALID_PII_OVERRIDE
New versions of Next.js aren't working with <styled jsx global> well. Instead of debugging, this commit moves those global styles to our global.css file. Also changes around some border colors in dark mode to reduce their prominence. Tested by poking around in dev mode and release mode.
618e55a to
6ca13c9
Compare
joelzwarrington
left a comment
joelzwarrington
left a comment
There was a problem hiding this comment.
Clicked around the preview and didn't notice any issues.
I did notice a flash when clicking on search results but I found this in production as well.
|
gah, the gif isn't high frame-rate enough to show the issue! 😭 |
2 participants
This PR makes a few changes to ensure the site's dependencies can be cleanly upgraded and the site can be developed locally.
799ead4 changes the way we import codemirror. Running
npm run devwould result in an SSR error (document is not defined), indicating that codemirror was trying to access DOM elements upon import, which is not allowed in recent Next.JS versions. This changes the import to be dynamic within a useeffect so that the import code only runs client-side.04b5821 updates our dependencies. I tried to get us as up-to-date as possible, but I didn't want to cross a major version boundary of Next.js to avoid the logic changes that might come about. I also resolved a peer dependency conflict between
react-codemirror2andcodemirrorthat would causenpm installto fail.During development, I noticed a weird bug with codemirror but confirmed that this bug doesn't show up in release builds. I added a comment in dbf5450 to warn others in the future so they don't go down a rabbit hole trying to solve it.
Finally, in 499c0ca, I fixed some global CSS styles that were not being applied properly. I assume that the Next.js update stopped supporting styled-jsx's
globalattribute; all those styles were broken. I moved those styles toglobal.csswhere they are now properly applied. While I was there, I also changed some of the border colors for the top nav and footer to be more subdued in dark mode.