fix: an unmatched strong run before emphasis stays literal - #4008
Merged
UziTech merged 1 commit intoAug 4, 2026
Conversation
|
@spokodev is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
@styfle any objections with merging this? |
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 4, 2026
## [18.0.9](v18.0.8...v18.0.9) (2026-08-04) ### Bug Fixes * an unmatched strong run before emphasis stays literal ([#4008](#4008)) ([e8544e6](e8544e6)) * Fix spurious deeper nesting in a blockquote continuation ([#4030](#4030)) ([452f1ed](452f1ed)) * pedantic **foo:** and **"word"** emphasis parsing ([#3999](#3999)) ([823093f](823093f))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The input
**a*b*cproduced malformed output.<p>*<em>a</em>b*c</p><p>**a<em>b</em>c</p>When the
**opener finds no closer, the lexer reprocesses from the second*of the run. That mid-run
*greedily pairs with the*beforeb, even thoughthat
*is itself the opener of*b*. The unmatched**should stay literalwhile the inner
*b*forms its own emphasis.The fix marks an opener that is reprocessed from inside its own delimiter run
(
prevCharequals the delimiter character) and stops it from closing against anambiguous delimiter that can also open, so that delimiter opens its own span
instead. This is distinct from the valid cases
**foo*,***foo**and****foo*, which close against unambiguous right delimiters and are preserved.All CommonMark and marked spec tests pass. Added a spec fixture for the case.