MLE-31901 Remove xdmp-login - #1108
Merged
Merged
Conversation
Removed `xdmp-login` from rest-evaluator role. Deleted rest-login role, since it only had the `xdmp-login` privilege. Removed the rest-login role from rest-reader user. Deleted rest-transform-user user, since it is not used anywhere.
jonmille
requested review from
RitaChen609,
ngodugu-marklogic,
rjdew-progress and
rjrudin
as code owners
August 12, 2026 18:21
There was a problem hiding this comment.
Pull request overview
This PR updates the test-app MarkLogic security configuration to remove the xdmp-login execute privilege and related security artifacts (roles/users) that were only present to support it.
Changes:
- Removed
xdmp-loginfrom therest-evaluatorrole privileges. - Deleted the
rest-loginrole (it only grantedxdmp-login) and removed it from therest-readeruser. - Deleted the unused
rest-transform-useruser definition.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test-app/src/main/ml-config/security/users/rest-transform-user.json | Removed unused user definition that depended on rest-login. |
| test-app/src/main/ml-config/security/users/rest-reader.json | Dropped the rest-login role assignment. |
| test-app/src/main/ml-config/security/roles/rest-login.json | Removed role that existed solely to grant xdmp-login. |
| test-app/src/main/ml-config/security/roles/rest-evaluator.json | Removed xdmp-login execute privilege from role privileges list. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rjdew-progress
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
xdmp-loginfrom rest-evaluator role.Deleted rest-login role, since it only had the
xdmp-loginprivilege.Removed the rest-login role from rest-reader user.
Deleted rest-transform-user user, since it is not used anywhere.
Jira Ticket: https://progresssoftware.atlassian.net/browse/MLE-31901
Related PR's where xdmp-login was introduced: