scaffold: add lucide-react + tw-animate-css to the web foundation#18
Merged
Conversation
trove-parity foundation extras (both actually used in trove): lucide-react (icons) + tw-animate-css (animation utilities). tailwind.css imports tw-animate-css; the example route exercises a lucide RocketIcon so neither ships as a dead dep. Green-on-arrival verified (fmt:check/lint/typecheck/test/build on a fresh target add).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First Tier-2 (trove-parity) slice: closes two real foundation-dep gaps the audit found —
lucide-react(icons) andtw-animate-css(animation utilities), both actually used in trove but absent from the scaffold.lucide-react+tw-animate-css(versions resolved bypnpm add).app/styles/tailwind.cssimportstw-animate-css.home.tsx) renders a lucideRocketIconin the CTA — so both deps are exercised, not dead weight (typecheck + build prove it).Green-on-arrival verified on a fresh
target add web: fmt:check / lint / typecheck / test / build all pass (lucide-react ^1.18, tw-animate-css ^1.4).mise run cigreen with a new render-test asserting the deps + the css import + the route usage.Deferred
@clerk/themes(audit's third suggestion) — without an opinionated baseTheme choice it'd be a dead dep; revisit if a themed-Clerk default is wanted.Part of Tier-2 web-app parity; the bigger SPA-mode + structural (go-service/monorepo) slices follow.