sender: compute shared hash over the transmitted (deflated) header form - #30
Merged
Conversation
The shared hash was computed before computeDeflate/applyTo mutated the wire header (deflate flag, compressed size, expanded size), so the recorded sha256 was of a form the receiving host never sees — receivers hash the header exactly as transmitted (SPEC "Message hash"). Replies to a locally-originated message then carried a psha256 no remote host could match, bouncing with code 6 (parent not found) even though the parent was delivered. Found live: only the root of a pid chain ever reached the remote host. Deflate now runs first and the hash is taken from the transmitted form; sharedHash()'s undeflated fallback remains only for local-only messages nothing external can reference. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared hash was computed before computeDeflate/applyTo mutated the wire header (deflate flag, compressed size, expanded size), so the recorded sha256 was of a form the receiving host never sees — receivers hash the header exactly as transmitted (SPEC "Message hash"). Replies to a locally-originated message then carried a psha256 no remote host could match, bouncing with code 6 (parent not found) even though the parent was delivered. Found live: only the root of a pid chain ever reached the remote host. Deflate now runs first and the hash is taken from the transmitted form; sharedHash()'s undeflated fallback remains only for local-only messages nothing external can reference.