fix(compiler): compile a file without a config, and cover the entry points - #3665
Conversation
🦋 Changeset detectedLatest commit: 2df6a7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 21 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
575b298 to
2df6a7d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3665 +/- ##
==========================================
+ Coverage 90.18% 90.23% +0.05%
==========================================
Files 412 412
Lines 19577 19577
Branches 3547 3547
==========================================
+ Hits 17655 17666 +11
+ Misses 1394 1383 -11
Partials 528 528 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
compileFileandcompileFileSyncboth declareconfigoptional and both threw aTypeErrorwhen it was omitted —getFsreadconfig.fileSystembefore it could fall back to the configured one. Nothing in the repo called them without a config, so nothing caught it.Tests cover that path plus the rest of the untested public entry points: reading through a
fileSystemhanded over in the config, the rejection when a file cannot be read,getRuntimeEntryFiles,getRuntimeVersion, and the async compile's error path.compiler/src/index.jsgoes from 47/58 statements and 24/32 branches to 57/57 and 42/49.