Skip to content

fix(compiler): compile a file without a config, and cover the entry points - #3665

Merged
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-marko-ts7-k2i7kg-compile-api
Jul 27, 2026
Merged

fix(compiler): compile a file without a config, and cover the entry points#3665
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-marko-ts7-k2i7kg-compile-api

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

compileFile and compileFileSync both declare config optional and both threw a TypeError when it was omitted — getFs read config.fileSystem before it could fall back to the configured one. Nothing in the repo called them without a config, so nothing caught it.

Tests cover that path plus the rest of the untested public entry points: reading through a fileSystem handed over in the config, the rejection when a file cannot be read, getRuntimeEntryFiles, getRuntimeVersion, and the async compile's error path. compiler/src/index.js goes from 47/58 statements and 24/32 branches to 57/57 and 42/49.

@changeset-bot

changeset-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2df6a7d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 21 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6cd1e435-ce97-4309-b487-87a98d08a0fe

📥 Commits

Reviewing files that changed from the base of the PR and between 48e290d and 2df6a7d.

📒 Files selected for processing (3)
  • .changeset/compile-file-without-config.md
  • packages/compiler/src/index.js
  • packages/compiler/test/compile.test.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dpiercey-ws-marko-ts7-k2i7kg-compile-api

Comment @coderabbitai help to get the list of available commands.

@DylanPiercey
DylanPiercey force-pushed the dpiercey-ws-marko-ts7-k2i7kg-compile-api branch from 575b298 to 2df6a7d Compare July 27, 2026 21:52
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.23%. Comparing base (48e290d) to head (2df6a7d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3665      +/-   ##
==========================================
+ Coverage   90.18%   90.23%   +0.05%     
==========================================
  Files         412      412              
  Lines       19577    19577              
  Branches     3547     3547              
==========================================
+ Hits        17655    17666      +11     
+ Misses       1394     1383      -11     
  Partials      528      528              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DylanPiercey
DylanPiercey merged commit 180251f into main Jul 27, 2026
11 checks passed
@DylanPiercey
DylanPiercey deleted the dpiercey-ws-marko-ts7-k2i7kg-compile-api branch July 27, 2026 21:56
@github-actions github-actions Bot mentioned this pull request Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant