fix(runtime-tags): allow content= on a void tag that declares the attribute - #3673
Conversation
…ttribute The void-tag guard added for `<input content=x>` rejected every `openTagOnly` tag, but `content` is a real html attribute on `<meta>` and compiled correctly before — so any page carrying og or twitter meta tags stopped compiling. The guard now fires only when the tag definition does not declare a `content` attribute, which still covers `<input>`, `<link>`, `<br>` and `<area>`. Static and dynamic `<meta content=>` are covered by a fixture.
🦋 Changeset detectedLatest commit: 232f0f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3673 +/- ##
=======================================
Coverage 90.32% 90.32%
=======================================
Files 412 412
Lines 19574 19575 +1
Branches 3545 3545
=======================================
+ Hits 17680 17681 +1
Misses 1370 1370
Partials 524 524 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The void-tag guard added for
<input content=x>rejectscontent=on everyopenTagOnlytag, butcontentis a real html attribute on<meta>—<meta property="og:image:width" content="1200">compiled correctly through 6.3.26 and stopped compiling in 6.3.27. That breaks any page carrying og or twitter meta tags; markojs.com itself no longer builds.marko-html.jsonalready draws the distinction:<meta>declares@content, while<input>,<link>,<br>and<area>do not. The guard now fires only when the tag definition declares nocontentattribute, so the unrenderable cases the original change targeted still error with the same message.Verified that static and dynamic
<meta content=>both survive: html output emits the attribute, and dom output sets it through_attrrather than dropping it. Newcontent-attr-metafixture covers both plus a client update.