Skip to content

fix(compiler): tailor the parse error for invalid tag variables - #3795

Merged
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-triage-agent-feedback-ojao9x
Aug 7, 2026
Merged

fix(compiler): tailor the parse error for invalid tag variables#3795
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-triage-agent-feedback-ojao9x

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

parseVar parses a tag variable as (str)=>{} to reuse Babel's binding-pattern grammar and relayed Babel's raw message, so <div/my-el>hi</div> failed with Binding invalid left-hand side in function parameter list. — naming a parameter list the author never wrote. That family of parse errors is now rewritten to \my-el` is not a valid tag variable; use a JavaScript identifier or destructuring patternwith a docs link, and anerror-tag-var-invalidfixture pins it. Resolves the correspondingagent-feedback/dx.md` entry.

parseVar reuses Babel's binding-pattern grammar via an arrow wrapper,
so a bad tag variable like <div/my-el> failed with 'Binding invalid
left-hand side in function parameter list' — naming syntax the author
never wrote. Rewrite that family of errors to name the tag variable
and link its docs.
@changeset-bot

changeset-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 450a27c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 772c8de6-00e5-4911-bc1d-aa6342517f08

📥 Commits

Reviewing files that changed from the base of the PR and between 3b569b5 and 450a27c.

⛔ Files ignored due to path filters (4)
  • packages/runtime-tags/src/__tests__/fixtures/error-tag-var-invalid/__snapshots__/error-compile-dom.debug.txt is excluded by !**/__snapshots__/** and included by **
  • packages/runtime-tags/src/__tests__/fixtures/error-tag-var-invalid/__snapshots__/error-compile-dom.txt is excluded by !**/__snapshots__/** and included by **
  • packages/runtime-tags/src/__tests__/fixtures/error-tag-var-invalid/__snapshots__/error-compile-html.debug.txt is excluded by !**/__snapshots__/** and included by **
  • packages/runtime-tags/src/__tests__/fixtures/error-tag-var-invalid/__snapshots__/error-compile-html.txt is excluded by !**/__snapshots__/** and included by **
📒 Files selected for processing (5)
  • .changeset/tag-var-parse-error.md
  • agent-feedback/dx.md
  • packages/compiler/src/babel-utils/parse.js
  • packages/runtime-tags/src/__tests__/fixtures/error-tag-var-invalid/template.marko
  • packages/runtime-tags/src/__tests__/fixtures/error-tag-var-invalid/test.ts

Comment @coderabbitai help to get the list of available commands.

@DylanPiercey
DylanPiercey merged commit 97ab05e into main Aug 7, 2026
8 checks passed
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.56%. Comparing base (3b569b5) to head (450a27c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3795   +/-   ##
=======================================
  Coverage   90.55%   90.56%           
=======================================
  Files         421      421           
  Lines       19849    19852    +3     
  Branches     3664     3664           
=======================================
+ Hits        17975    17979    +4     
+ Misses       1331     1329    -2     
- Partials      543      544    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot mentioned this pull request Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant