fix(compiler): tailor the parse error for invalid tag variables - #3795
Conversation
parseVar reuses Babel's binding-pattern grammar via an arrow wrapper, so a bad tag variable like <div/my-el> failed with 'Binding invalid left-hand side in function parameter list' — naming syntax the author never wrote. Rewrite that family of errors to name the tag variable and link its docs.
🦋 Changeset detectedLatest commit: 450a27c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 53 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (5)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3795 +/- ##
=======================================
Coverage 90.55% 90.56%
=======================================
Files 421 421
Lines 19849 19852 +3
Branches 3664 3664
=======================================
+ Hits 17975 17979 +4
+ Misses 1331 1329 -2
- Partials 543 544 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
parseVarparses a tag variable as(str)=>{}to reuse Babel's binding-pattern grammar and relayed Babel's raw message, so<div/my-el>hi</div>failed withBinding invalid left-hand side in function parameter list.— naming a parameter list the author never wrote. That family of parse errors is now rewritten to\my-el` is not a valid tag variable; use a JavaScript identifier or destructuring patternwith a docs link, and anerror-tag-var-invalidfixture pins it. Resolves the correspondingagent-feedback/dx.md` entry.