Skip to content

fix: clone prototype-less metadata objects in shallowClone - #3846

Merged
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-triage-agent-feedback-ojao9x
Aug 8, 2026
Merged

fix: clone prototype-less metadata objects in shallowClone#3846
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-triage-agent-feedback-ojao9x

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

shallowClone dispatched on v.constructor with a case null: arm for prototype-less objects — but Object.create(null).constructor is undefined, so the arm was dead and such metadata crashed the compile with Cannot read properties of undefined (reading 'name'). The case now matches undefined and the default's message survives falsy constructors.

@changeset-bot

changeset-bot Bot commented Aug 8, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e48fa00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e455d5ac-6338-41e5-9a7f-38fb5cb24c06

📥 Commits

Reviewing files that changed from the base of the PR and between de8fb5f and e48fa00.

📒 Files selected for processing (3)
  • .changeset/shallow-clone-null-proto.md
  • agent-feedback/bugs.md
  • packages/compiler/src/babel-plugin/index.js

Comment @coderabbitai help to get the list of available commands.

@DylanPiercey
DylanPiercey merged commit 1a881a5 into main Aug 8, 2026
8 checks passed
@codecov

codecov Bot commented Aug 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.64%. Comparing base (de8fb5f) to head (e48fa00).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/compiler/src/babel-plugin/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3846   +/-   ##
=======================================
  Coverage   90.64%   90.64%           
=======================================
  Files         421      421           
  Lines       19953    19953           
  Branches     3705     3705           
=======================================
  Hits        18087    18087           
  Misses       1322     1322           
  Partials      544      544           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot mentioned this pull request Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant