fix: invalidate the per-translator taglib memo on register and clearCaches - #3849
Conversation
🦋 Changeset detectedLatest commit: 10e334f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 35 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3849 +/- ##
=======================================
Coverage 90.64% 90.65%
=======================================
Files 421 421
Lines 19956 19958 +2
Branches 3705 3705
=======================================
+ Hits 18090 18092 +2
Misses 1322 1322
Partials 544 544 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
buildLookupmemoizes each translator'sregisteredTaglibs.concat(translator taglibs)array, butclearCaches()only reset the loader, finder and lookup caches — so a taglib registered through the publictaglib.register()after any compile was dropped forever for that translator, even after the documented cache clear. Bothregister()andclearCaches()now clear the memo; the fresh array identity also invalidates the finder's identity-keyed cache from the previous fix, so discovery re-runs with the new set.