Skip to content

fix: parent example renders non-existent value - #271

Merged
DylanPiercey merged 1 commit into
marko-js:mainfrom
caseycarroll:patch-2
Aug 7, 2026
Merged

fix: parent example renders non-existent value#271
DylanPiercey merged 1 commit into
marko-js:mainfrom
caseycarroll:patch-2

Conversation

@caseycarroll

@caseycarroll caseycarroll commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Fixes a minor mistake in the controllable docs. Example attempts to render count in the parent component, but that value doesn’t exist in that scope.

Also edit count examples to render count rather than input.count since we're assigning input.count to count in the <let>

Unsure if rendering input.count in the controllable examples was intentional. I'm open to removing that edit if it was.

@changeset-bot

changeset-bot Bot commented Aug 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ea230b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 2, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: caseycarroll / name: Casey Carroll (ea230b2)

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Updated controllable counter examples to render local count state. Updated the binding-shorthand example to render the parent’s parentCount value.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description clearly explains the documentation corrections and matches the changeset.
Title check ✅ Passed The title clearly identifies the primary documentation fix involving a non-existent parent-scope value.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@caseycarroll caseycarroll changed the title fix: parent example outputs non-existent value fix: parent example renders non-existent value Aug 2, 2026
@DylanPiercey
DylanPiercey merged commit abb2f56 into marko-js:main Aug 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants