Skip to content

Serve marko's code-split runtime dist to the playground - #274

Merged
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-marko-trailing-bracket-8aqu7u
Aug 7, 2026
Merged

Serve marko's code-split runtime dist to the playground#274
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-marko-trailing-bracket-8aqu7u

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

marko 6.3.33 builds each *.feat module as a separate entry, so the runtime dist is code-split and marko/dom imports a hashed chunk the playground could not resolve (it inlined only the four entry files). A build-time virtual module now captures the full runtime dist, and the playground resolves entries, *.feat imports, and chunk-relative imports against it. A regression test asserts every import within the captured files resolves.

@changeset-bot

changeset-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: bdc6d3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f60b1751-e52d-4de3-8c89-84c6574b82a3

📥 Commits

Reviewing files that changed from the base of the PR and between abb2f56 and bdc6d3e.

📒 Files selected for processing (6)
  • src/types/stubs.d.ts
  • src/util/marko-runtime-files.ts
  • src/util/workspace/marko-plugin.test.ts
  • src/util/workspace/marko-plugin.ts
  • vite.config.ts
  • vitest.config.ts

Comment @coderabbitai help to get the list of available commands.

@DylanPiercey
DylanPiercey merged commit 0807935 into main Aug 7, 2026
4 checks passed
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

PR Preview Deployed

Your changes are live at markojs.com/previews/pr-274.

commit bdc6d3e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant