Skip to content

Dtraj api#39

Merged
marscher merged 4 commits intodevelfrom
dtraj_api
Jul 29, 2015
Merged

Dtraj api#39
marscher merged 4 commits intodevelfrom
dtraj_api

Conversation

@franknoe
Copy link
Copy Markdown
Contributor

Making all discrete_trajectory functions available as api

@franknoe
Copy link
Copy Markdown
Contributor Author

Can someone help me with these Appveyor failures? I think they are windows failures, here the tests run well.

@marscher
Copy link
Copy Markdown
Member

It looks like the file used to write the dtraj is still opened in write mode, when it is being tried to read again by the same doctest. This is forbidden in Windows.

@franknoe
Copy link
Copy Markdown
Contributor Author

I did not change these functions, but just moved the doc strings of the
former api.py to discrete_trajectories.py and then replaced api.py (that
was just doing calls to discrete_trajectories.py) by
discrete_trajectories.py. So I don't see how this could have worked
before. Could you or Benjamin look into this?

Am 28/07/15 um 12:21 schrieb Martin K. Scherer:

It looks like the file used to write the dtraj is still opened in
write mode, when it is being tried to read again by the same doctest.
This is forbidden in Windows.


Reply to this email directly or view it on GitHub
#39 (comment).


Prof. Dr. Frank Noe
Head of Computational Molecular Biology group
Freie Universitaet Berlin

Phone: (+49) (0)30 838 75354
Web: research.franknoe.de

Mail: Arnimallee 6, 14195 Berlin, Germany

@franknoe
Copy link
Copy Markdown
Contributor Author

Actually the tests were failing before my commit, I just realized that I pushed that branch before committing.

@marscher
Copy link
Copy Markdown
Member

marscher commented Jul 28, 2015 via email

@franknoe
Copy link
Copy Markdown
Contributor Author

I just realized that I forgot to commit, so the merge would have been
ineffective without me pushing again.

Am 28/07/15 um 12:35 schrieb Martin K. Scherer:

please do not refactor code based on open PRs. It was not yet merged,
because appveyor was failing, because we've recently enabled doctesting
on all platforms.


Reply to this email directly or view it on GitHub
#39 (comment).


Prof. Dr. Frank Noe
Head of Computational Molecular Biology group
Freie Universitaet Berlin

Phone: (+49) (0)30 838 75354
Web: research.franknoe.de

Mail: Arnimallee 6, 14195 Berlin, Germany

marscher added a commit that referenced this pull request Jul 29, 2015
@marscher marscher merged commit 35b16c4 into devel Jul 29, 2015
@marscher marscher deleted the dtraj_api branch July 29, 2015 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants