Skip to content

fix(desktop): repair fullscreen window controls - #271

Merged
murongg merged 1 commit into
mainfrom
fix/fullscreen-menu-command
Jun 14, 2026
Merged

fix(desktop): repair fullscreen window controls#271
murongg merged 1 commit into
mainfrom
fix/fullscreen-menu-command

Conversation

@murongg

@murongg murongg commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Route the desktop View > Enter Full Screen menu command through Markra's frontend fullscreen handler on non-macOS platforms.
  • Preserve macOS's native fullscreen menu role so menu-bar fullscreen stays system-managed.
  • Make the self-drawn green traffic-light button toggle true fullscreen instead of only maximizing to the desktop viewport.
  • Minimize through a native desktop command; on macOS it exits system fullscreen first, then miniaturizes the window after the fullscreen transition starts.
  • Keep the app test harness Tauri mock in sync with the fullscreen export used by App tests.

Why

  • Fixes the Windows 11 menu fullscreen no-op reported in [Bug]: 全屏功能无效 #258.
  • Avoids regressing macOS native fullscreen behavior when entering fullscreen from the menu.
  • Keeps self-drawn macOS traffic-light controls aligned with native behavior for fullscreen and minimize-from-fullscreen.

Validation

  • pnpm exec vitest run src/components/MacWindowControls.test.tsx passed
  • pnpm exec vitest run src/runtime/tauri/window.test.ts passed
  • cargo fmt --manifest-path apps/desktop/src-tauri/Cargo.toml --check passed
  • cargo test --manifest-path apps/desktop/src-tauri/Cargo.toml --locked passed
  • pnpm test passed
  • pnpm run typecheck:test passed
  • pnpm build passed

Risk

  • Manual packaged Windows/macOS app QA is not included in this branch; behavior is covered by focused tests, local build, and GitHub Actions.

Closes #258

@vercel

vercel Bot commented Jun 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jun 14, 2026 7:54am

@murongg
murongg force-pushed the fix/fullscreen-menu-command branch from efc1b8a to aba794b Compare June 14, 2026 07:46
@murongg murongg changed the title fix(desktop): route fullscreen menu command fix(desktop): repair fullscreen window controls Jun 14, 2026
@murongg
murongg force-pushed the fix/fullscreen-menu-command branch from aba794b to f5d16a2 Compare June 14, 2026 07:54
@murongg
murongg marked this pull request as ready for review June 14, 2026 07:54
@murongg
murongg merged commit 5ad40a1 into main Jun 14, 2026
4 checks passed
@murongg
murongg deleted the fix/fullscreen-menu-command branch June 14, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 全屏功能无效

1 participant