fix(desktop): repair fullscreen window controls - #271
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
murongg
force-pushed
the
fix/fullscreen-menu-command
branch
from
June 14, 2026 07:46
efc1b8a to
aba794b
Compare
murongg
force-pushed
the
fix/fullscreen-menu-command
branch
from
June 14, 2026 07:54
aba794b to
f5d16a2
Compare
murongg
marked this pull request as ready for review
June 14, 2026 07:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Validation
pnpm exec vitest run src/components/MacWindowControls.test.tsxpassedpnpm exec vitest run src/runtime/tauri/window.test.tspassedcargo fmt --manifest-path apps/desktop/src-tauri/Cargo.toml --checkpassedcargo test --manifest-path apps/desktop/src-tauri/Cargo.toml --lockedpassedpnpm testpassedpnpm run typecheck:testpassedpnpm buildpassedRisk
Closes #258