feat(app): add dropped file tab option#588
Open
murongg wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Preserve existing workspace state when dropped files replace empty tabs, and route folder drops to a new window when other tabs contain work. Refs #576
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Opening a file currently establishes its containing folder as a workspace, so the new-window behavior is intentional. This option supports the requested tab workflow without changing the default workspace model or discarding existing tab state.
Validation
pnpm --filter @markra/shared test— 7 test files and 62 tests passedpnpm --filter @markra/shared build— passedpnpm --filter @markra/app exec vitest run src/hooks/useMarkdownDocument.test.tsx— 82 tests passedpnpm --filter @markra/app typecheck:test— passedpnpm --filter @markra/app test— 127 test files and 1445 tests passedpnpm --filter @markra/desktop build— production build and 15 vendor chunk imports passedRisk
falseCloses #576