Skip to content

fix(windows): open new windows from shortcuts and drops - #595

Merged
murongg merged 1 commit into
v2from
fix/windows-window-opening
Jul 28, 2026
Merged

fix(windows): open new windows from shortcuts and drops#595
murongg merged 1 commit into
v2from
fix/windows-window-opening

Conversation

@murongg

@murongg murongg commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Restore Windows Ctrl+N and File > New by invoking the native blank editor window command through the runtime bridge.
  • Open dropped files and folders outside the active workspace in a new native window while preserving tab reuse for in-workspace paths.
  • Add regression coverage for the shortcut, title-bar menu, runtime command bridge, and Windows path-boundary cases.

Why

  • macOS already receives Cmd+N through its native AppKit menu, while the Windows self-drawn chrome lacked the equivalent shortcut and its New menu action targeted the current document.
  • External drops could attach to the current workspace instead of preserving the one-workspace-per-window boundary.

Validation

  • pnpm --filter @markra/app test — 127 files and 1451 tests passed.
  • pnpm --filter @markra/desktop test — 15 files and 143 tests passed.
  • pnpm -r --if-present typecheck:test — all 11 applicable workspace projects passed.
  • pnpm --filter @markra/desktop build — production build and chunk verification passed.
  • cargo test in apps/desktop/src-tauri — 258 tests passed.
  • Not run: physical Windows smoke test, because the current development environment is macOS.

Risk

  • Shortcut interception is limited to Windows self-drawn desktop chrome.
  • Drop routing changes only targets outside the current workspace; in-workspace tab behavior remains unchanged.

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jul 28, 2026 10:06am

@murongg
murongg merged commit ca9558d into v2 Jul 28, 2026
21 checks passed
@murongg
murongg deleted the fix/windows-window-opening branch July 28, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant