fix(windows): open new windows from shortcuts and drops - #595
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ctrl+Nand File > New by invoking the native blank editor window command through the runtime bridge.Why
Cmd+Nthrough its native AppKit menu, while the Windows self-drawn chrome lacked the equivalent shortcut and its New menu action targeted the current document.Validation
pnpm --filter @markra/app test— 127 files and 1451 tests passed.pnpm --filter @markra/desktop test— 15 files and 143 tests passed.pnpm -r --if-present typecheck:test— all 11 applicable workspace projects passed.pnpm --filter @markra/desktop build— production build and chunk verification passed.cargo testinapps/desktop/src-tauri— 258 tests passed.Risk