Skip to content

fix(editor): sync visual table edits to markdown - #598

Merged
murongg merged 1 commit into
v2from
fix/table-source-sync
Jul 28, 2026
Merged

fix(editor): sync visual table edits to markdown#598
murongg merged 1 commit into
v2from
fix/table-source-sync

Conversation

@murongg

@murongg murongg commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • handle input and composition events on the shared contenteditable table host
  • resolve the active visual cell and write its serialized value back to Markdown while preserving caret and IME behavior
  • add editor and app regressions for split-source synchronization and saving

Why

Browsers target editing events at the shared contenteditable table element. The previous cell-level listeners could miss real input, leaving the visual cell changed while the Markdown source stayed stale.

Validation

  • pnpm --filter @markra/editor test -- src/codemirror/table.test.ts — 38 tests passed
  • pnpm --filter @markra/editor build — passed
  • pnpm --filter @markra/editor typecheck:test — passed
  • pnpm --filter @markra/app test -- src/App.test.tsx -t "syncs visual table cell edits to source in split mode and saves them" — passed
  • pnpm --filter @markra/app build — passed
  • pnpm --filter @markra/app typecheck:test — passed

Risk

Low and localized to visual GFM table editing. Existing table coverage, including IME and inline content behavior, remains green.

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jul 28, 2026 2:14pm

@murongg
murongg merged commit 8c56cb1 into v2 Jul 28, 2026
21 checks passed
@murongg
murongg deleted the fix/table-source-sync branch July 28, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant