fix(editor): support line breaks in visual table cells - #632
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shift+Enterinsert a persisted<br>in visual table cells while keeping focus on the new visual lineEnterbehavior that finishes cell editing<br>Why
Visual table cells handled every Enter keypress as a request to leave editing, so the existing source-mode
Shift+Enterbehavior was unavailable in preview mode. This predates and is independent of #630.Validation
pnpm --filter @markra/editor test— 33 files, 387 tests passedpnpm --filter @markra/app test -- MarkdownExportDocument.test.tsx— 9 tests passedpnpm --filter @markra/editor build— passedpnpm --filter @markra/editor typecheck:test— passedgit diff --check— passedFirst<br>SecondRisk
<br>rendering/serialization inside visual table cells