fix(editor): preserve rich HTML paste formatting - #645
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
div/pwrappers without semantic code contentWhy
Rich content copied from ChatGPT, Codex, and similar sources can include incidental Markdown-looking text alongside valid HTML. The editor previously selected the plain-text fallback or flattened the whole payload when it encountered a styled code region. Block-styled file badges inside anchors could also be parsed as empty links plus detached code blocks. Desktop right-click paste discarded HTML entirely.
Validation
pnpm --filter @markra/editor test— 447 tests passedpnpm --filter @markra/app test -- context-menu-items.test.ts— 14 tests passedpnpm --filter @markra/app test— 1,489 tests passedpnpm --filter @markra/desktop test— 149 tests passedcargo testinapps/desktop/src-tauri— 271 tests passedcargo fmt --checkpassedgit diff --checkpassedRisk
The change is scoped to clipboard HTML conversion and native context-menu paste. Plain text and raw Markdown fallback behavior remains covered. Styled link normalization requires a compact single-line
div/pwrapper with monospace or preformatted whitespace evidence. Ordinary linked cards, semanticpre/codecontent, multiline links, and code blocks outside links remain on their existing conversion paths. Proprietary class-only rich text without semantic markup or inline preformatted styles remains best-effort.Related Issues
Refs #631