fix: Internal image cache isn't reset if failed to load (#3001)

[kiyoka]

In the loadImageAsync function, images that failed last time will try to be reloaded.

Q	A
Bug fix?	yes
New feature?	no
Breaking changes?	no
Deprecations?	no
New tests added?	not needed
Fixed tickets	Fixes #3001
License	MIT

[fxha]

Hey thanks for the fix, but unfortunately I noticed that this will lead to flickering if you type text or change cursor position because the loading animation is applied to the image for a very short time before falling back to the failed state.

[kiyoka]

Oops, I'll think of another approach.
This issue is closed.

[kiyoka]

I followed the cause of the flickering.
The reason is that the CSS ag-image-fail and ag-image-loading have different heights, so they flicker when the image is reloaded.
Why don't we prepare ag-image-reloading and design it at the same height as ag-image-fail?
Images that failed to load last time will start from the ag-image-reloading state.

[fxha]

Why don't we prepare ag-image-reloading and design it at the same height as ag-image-fail?

It seems to be a reasonable idea to me 👍

Another option would be to provide a manually reload button? @Jocs @kiyoka

[kiyoka]

Another option would be to provide a manually reload button? @Jocs @kiyoka

In most cases, I believe there are a few images that fail to load.
User should fix the link soon, so automatic reloading is fine.

[Jocs]

This project recently merged a large refactor (electron-vite migration, PR #4001) that upgraded dependencies and fixed several issues.

Please review this PR and let us know if it is still needed, or if the changes have already been addressed upstream.