refactor(renderer): type sidebar + top-level SFCs — drop @ts-nocheck (TS migration follow-up 4/6)

[Jocs]

Summary

Part 4/6 of the TypeScript migration deferred-work cleanup. Drops // @ts-nocheck from the sidebar SFCs and the top-level page shells.

Stacked on #4249 (ts/store-setup-rewrite). Will be retargeted to develop automatically once #4249 merges.

Changes (13 files)

• 9 sideBar SFCs: tree.vue, treeFile.vue, treeFolder.vue, treeOpenedTab.vue, icon.vue, index.vue, search.vue, searchResultItem.vue, toc.vue.
• 3 top-level pages: Main.vue, pages/app.vue, pages/preference.vue.
• New shared types in src/renderer/src/components/sideBar/types.ts:
  • TreeFileNode, TreeFolderNode, TreeNode — narrow versions of the runtime shapes built by treeCtrl.ts.
  • SearchRange, SearchMatch, SearchResult — ripgrep result shape consumed by search.vue / searchResultItem.vue.
  • TabDescriptor — alias of IFileState at the sideBar boundary.
• src/types/global.d.ts — broadened window.marktext to include initialState and paths.

Notable adjustments

• tree.vue — added a createCacheDirname computed because the underlying createCache ref union ({ dirname, type } | {}) doesn't expose dirname directly.
• search.vue — refactored to hold the CancellableSearch handle separately from the chained .then().catch() (the chained promise becomes Promise<void> and loses .cancel).
• app.vue — tightened the addStyles boundary with explicit coalescing against DEFAULT_STYLE because URL-parsed initialState carries nullables.
• app.vue / preference.vue — spelled out /index.vue on directory imports: vue-tsc's bundler resolver doesn't follow Vite's directory-with-index.vue convention without an explicit path.

Test plan

• pnpm typecheck — clean
• pnpm test:unit — 550/550 pass
• pnpm exec playwright test test/e2e/launch.spec.ts test/e2e/tabs.spec.ts — 3/3 pass

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR is part of the renderer TypeScript migration follow-ups: it removes // @ts-nocheck from the sidebar and top-level page SFCs by adding explicit prop/types, and introduces shared sidebar type definitions plus a broader window.marktext global type.

Changes:

• Removed // @ts-nocheck across sidebar components and top-level page shells; added explicit prop typings and safer null-handling in templates/handlers.
• Introduced shared sidebar domain types (Tree*, search result shapes, TabDescriptor) to reduce ad-hoc any/casts across SFCs.
• Expanded window.marktext typing to include initialState and paths to support typed bootstrap data access.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/types/global.d.ts	Extends window.marktext typing for bootstrap initialState and paths.
src/renderer/src/pages/preference.vue	Drops @ts-nocheck, uses explicit .vue imports, and hardens initial theme style application.
src/renderer/src/pages/app.vue	Drops @ts-nocheck, strengthens types around timers/props, and coalesces nullable bootstrap style values.
src/renderer/src/Main.vue	Removes @ts-nocheck (empty script setup).
src/renderer/src/components/sideBar/types.ts	Adds shared TS types for sidebar tree/search/tab surfaces.
src/renderer/src/components/sideBar/treeOpenedTab.vue	Adds typed props (TabDescriptor) and null-safe current file comparisons.
src/renderer/src/components/sideBar/treeFolder.vue	Adds typed props/refs and explicit return types for handlers.
src/renderer/src/components/sideBar/treeFile.vue	Adds typed props/refs and null-safe current file comparisons.
src/renderer/src/components/sideBar/tree.vue	Adds typed props and a typed accessor for createCache.dirname to remove template casts.
src/renderer/src/components/sideBar/toc.vue	Drops @ts-nocheck and types the TOC click handler payload.
src/renderer/src/components/sideBar/searchResultItem.vue	Drops @ts-nocheck and types computed values/handlers for search result rendering.
src/renderer/src/components/sideBar/search.vue	Drops @ts-nocheck, types search state, and refactors cancellable ripgrep usage.
src/renderer/src/components/sideBar/index.vue	Drops @ts-nocheck, types refs/width computations, and guards missing drag bar element.
src/renderer/src/components/sideBar/icon.vue	Drops @ts-nocheck and makes computed icon classes null-safe.

Comments suppressed due to low confidence (1)

src/renderer/src/components/sideBar/search.vue:264

• The parameter type executeSearch: boolean | unknown = true collapses to unknown (since unknown absorbs unions), which defeats the intent of typing and makes if (executeSearch) effectively accept any value. Prefer a plain boolean parameter (and, if callers may pass non-boolean, coerce/validate inside) so the function’s contract is clear and type-safe.

const handleFindInFolder = (executeSearch: boolean | unknown = true): void => {
  nextTick(() => {
    if (searchEl.value) {
      searchEl.value.focus()
      // `searchMatches.value` may carry a `selectedText` populated elsewhere
      // (legacy contract from CodeMirror / find-in-page). Narrow defensively.
      const selectedText = (searchMatches.value as { selectedText?: string } | undefined)
        ?.selectedText
      if (selectedText) {
        keyword.value = selectedText
        if (executeSearch) {
          search()
        }
      }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Jocs]

Fixed in acf88e9b. Now narrows to a non-empty string and bails out early:

if (typeof data.slug !== 'string' || data.slug.length === 0) return
bus.emit('scroll-to-header', data.slug)

[Jocs]

Fixed in acf88e9b — typed as TreeNode | null with a comment noting that the project store seeds it as null until a folder is opened, and the template's v-if="projectTree" guard now matches the prop type.

[github-actions]

Build artifacts for PR #4252:

Run: https://github.com/marktext/marktext/actions/runs/26285880720

Artifact	Size	Link
marktext-macos-x64	534.9 MB	Download
marktext-linux	594.5 MB	Download
marktext-windows	272.8 MB	Download
marktext-macos-arm64	534.6 MB	Download