Re-vendor the amended standard and the 351 vector corpus - #7
Merged
Conversation
STANDARD.md and conformance/ come from mas-bandwidth/serialize at 39cc8543, which prints the whole 112-byte golden message and adds the vector that holds a degenerate fixed point field to the terminal failure rule. stepFromWords gains the six spellings the corpus format now lists: double, uint128, int64, int128, int_relative and compressed_float. The step machine already ran every one of them for the single operation files, so this is parsing alone. The interop job takes one pin. SERIALIZE_TAG, now v1.16.2, checks out the reference once and both C++ halves are built from that checkout; a step proves the vendored corpus is the pinned release's own, which is what SERIALIZE_CORPUS_COMMIT used to stand in for. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STANDARD.md and
conformance/are re-vendored from mas-bandwidth/serialize at 39cc8543, the commit tagged v1.16.2. Two vectors are new: the whole 112-byte golden message, whose bytes the document now prints in full, and a twin of the terminal failure vector whose successor is a degenerate fixed point field.stepFromWordsgains the six spellings the corpus format now lists:double,uint128,int64,int128,int_relativeandcompressed_float. The step machine already ran every one of them for the single operation files, so this is parsing alone, and the step list is aList, so the 28 operation golden needs no budget change.The corpus runs green here: 351 vectors from 18 files, 196 writer checks, 10 measure checks, 0 failures, assertions on and off.
One pin. The interop job used to carry two,
SERIALIZE_TAGfor the wire exchange andSERIALIZE_CORPUS_COMMITfor the reference conformance runner. It now clones the reference once, atSERIALIZE_TAG, and builds both C++ halves from that checkout, with a step proving the vendored corpus is byte for byte the pinned release's own. The second pin existed because the corpus moved ahead of the newest release; a release that carries the corpus removes the reason for it.SERIALIZE_TAGmoves to v1.16.2. That tag does not exist until the reference is tagged, so the interop job is red until then and this PR waits on it.Version stays 1.1.2, which is the release this corpus ships in.