Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/codeql.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
run: Scripts/setup_workflow_repo

- name: 🔩 Initialize CodeQL
uses: github/codeql-action/init@f205ea1c3313d32999d8d6a48b4f6530d4437b38 # v4.37.4
uses: github/codeql-action/init@d1ba80a13dd99fba24a470575428917156a28b43 # v4.37.5
with:
languages: ${{matrix.language}}
build-mode: ${{matrix.build-mode}}
Expand All @@ -60,6 +60,6 @@ jobs:
Scripts/build codeql -c release

- name: 🔍 Perform CodeQL analysis
uses: github/codeql-action/analyze@f205ea1c3313d32999d8d6a48b4f6530d4437b38 # v4.37.4
uses: github/codeql-action/analyze@d1ba80a13dd99fba24a470575428917156a28b43 # v4.37.5
with:
category: /language:${{matrix.language}}
2 changes: 1 addition & 1 deletion .github/workflows/scorecard.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@ jobs:
retention-days: 5

- name: Upload to code-scanning
uses: github/codeql-action/upload-sarif@f205ea1c3313d32999d8d6a48b4f6530d4437b38 # v4.37.4
uses: github/codeql-action/upload-sarif@d1ba80a13dd99fba24a470575428917156a28b43 # v4.37.5
with:
sarif_file: results.sarif
4 changes: 2 additions & 2 deletions .markdownlint-cli2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# .markdownlint-cli2.yaml
# mas
#
# markdownlint-cli2 0.23.1 / markdownlint 0.41.1
# markdownlint-cli2 0.23.2 / markdownlint 0.41.1
#
---
gitignore: true
Expand All @@ -22,7 +22,7 @@ config:
emphasis-style:
style: underscore
fenced-code-language:
allowed_languages: [console, shell, swift]
allowed_languages: [console, shell]
language_only: true
heading-style:
style: atx
Expand Down
41 changes: 34 additions & 7 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ Read it before making repository changes.

- `main` is the trunk
- Branch topics from `main`
- Before committing (to preserve tokens, agents should skip steps 2 & 3):
- Before committing (to preserve tokens, agents should skip all of the following
steps unless explicitly directed to perform them):
1. Add or edit tests for non-trivial changes
2. Repeatedly run `Scripts/format` until no modifications are made
3. Repeatedly run `Scripts/lint` & fix all violations until no violations are
Expand All @@ -36,11 +37,35 @@ Read it before making repository changes.

## Content Formatting

- **Newlines:** UNIX (i.e. `\n`)
- **Indentation:** Tabs (width: 2)
- **Max line length:** 120 characters (tabs count as 2 characters)
- **Newlines:** Unix (i.e. `\n`)
- **Indentation:** Tabs (2 characters wide) for all files unless otherwise
specified; 2 spaces for YAML; 1 space for Markdown
- **Max line length:** 120 characters for all files unless otherwise specified
(tabs count as 2 characters); 80 for Markdown; unlimited for header, JSON &
swiftformat
- **Unnecessary trailing whitespace:** Remove
- **File ends:** Single newline
- **Quoting:** Quote strings only when necessary, preferring the most literal
format that works over more interpreted formats; if multiple quote syntaxes
are functionally equivalent, prefer the visually lightest, e.g., prefer single
quotes over double quotes if they are functionally equivalent
- **Text**: In documentation, comments, strings, etc.:
- **Commas:** Use Oxford commas for lists
- **Ampersands:** Prefer `&` to `and` (omit Oxford comma before `&`)
- **Exceptions:** `and` should be used in `and/or` & after a comma that
separates distinct clauses (but not in a list)
- **Quotes**: The enclosing quotations marks of a quote at the end of a
sentence (iff the whole sentence isn't a quote) should not enclose the
terminal punctuation mark of the encompassing sentence
- **Iff**: Use `iff` as `if & only if`

### Markdown Guidelines

- **Style:** GitHub-Flavored Markdown (GFM), ATX headings, backtick-fenced code
blocks with language identifier, underscore emphasis, asterisk strong & hyphen
bullets
- **HTML:** Limit to HTML supported by GFM that doesn't have a native GFM
equivalent

## Refactoring Rules

Expand Down Expand Up @@ -129,10 +154,11 @@ Commands follow a consistent structure:
### Style Essentials

- Name most function parameters
- Capitalize acronym & initialism characters consistently (e.g., `HTTPRequest`,
not `HttpRequest`)
- Capitalize acronym & initialism characters consistently (e.g., `ADAM`, `API`,
`HTTPRequest`, `JSON`)
- Shadow variables if the respective original will no longer be used
- Strongify weak references instead of evaluating them multiple times
- Group computed properties below stored properties

### Code Preference Hierarchies

Expand Down Expand Up @@ -279,7 +305,8 @@ Within this section & all subsections, `X` is a placeholder for any type name.

### Testing Requirements

- Add tests for all non-trivial changes
- Add tests for all non-trivial changes (to preserve tokens, agents should not
add tests unless explicitly directed to do so)
- Implement in [Swift Testing](https://github.com/swiftlang/swift-testing)
- Derive test file paths from source file paths:
- replace the `Sources/mas` source path folder prefix with `Tests/MASTests`
Expand Down
6 changes: 3 additions & 3 deletions Brewfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
brew "actionlint" # 1.7.12
brew "editorconfig-checker" # 3.8.0
brew "gh" # 2.96.0
brew "gh" # 2.97.0
brew "git" # 2.55.0
brew "ipsw" # 3.1.705
brew "markdownlint-cli2" # 0.23.1
brew "ipsw" # 3.1.707
brew "markdownlint-cli2" # 0.23.2
brew "periphery" if MacOS.version >= :sequoia && `/usr/bin/arch` == "arm64" # 3.8.0
brew "shellcheck" # 0.11.0
brew "swiftformat" # 0.62.1
Expand Down
106 changes: 0 additions & 106 deletions GEMINI.md

This file was deleted.

14 changes: 7 additions & 7 deletions Package.resolved

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,14 @@ _ = Package(
platforms: [.macOS(.v13)],
products: [.executable(name: "mas", targets: ["mas"])],
dependencies: [
.package(url: "https://github.com/KittyMac/Sextant", from: "0.4.40"),
.package(url: "https://github.com/KittyMac/Sextant", from: "0.4.41"),
.package(url: "https://github.com/apple/swift-argument-parser", from: "1.8.2"),
.package(url: "https://github.com/apple/swift-atomics", from: "1.3.1"),
.package(url: "https://github.com/apple/swift-collections", from: "1.6.0"),
.package(url: "https://github.com/attaswift/BigInt", from: "6.0.0"),
.package(url: "https://github.com/rarestype/swift-json", from: "3.5.0"),
.package(url: "https://github.com/scinfu/SwiftSoup", from: "2.13.7"),
.package(url: "https://github.com/swiftlang/swift-subprocess", from: "0.5.0"),
.package(url: "https://github.com/swiftlang/swift-subprocess", from: "1.0.0"),
],
targets: [
.plugin(name: "MASBuildToolPlugin", capability: .buildTool()),
Expand Down
Loading
Loading