Add portable Sampled Values engineering evidence bundles - #108
Merged
Conversation
masarray
marked this pull request as ready for review
July 28, 2026 05:44
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8fcea9c444
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Close the P1 evidence gaps after the bounded two-cycle SV snapshot and P0 safety hardening. A capture can now leave ARSAS as a portable, integrity-checked engineering evidence package instead of remaining only on screen.
Evidence bundle
Each exported ZIP contains exactly seven auditable entries:
manifest.json— selection, observed stream, verdict, actual capture interval, timebase, transport, continuity, payload and proof boundaryprovenance.json— ARSAS version plus immutable ARIEC61850 repository/ref/commit/source-PR provenancesamples.csv— invariant-culture raw signed numeric lanes with sample index and cycle positionwaveform.png— static waveform proof rendered from the accepted snapshotdiagnostics.txt— explicit continuity counts and engine diagnosticsREADME.txt— human-readable capture/export timestamps, usage and non-claim boundarySHA256SUMS.txt— integrity hashes for every evidence payload fileEvidence integrity
captureInterval.startedAtUtcandcompletedAtUtcare distinct from bundlegeneratedAtUtcsourcePullRequestlock key and remains compatible withpairedPullRequestSmvSnapshotResult.IsCleanProofUX
Export evidencebecomes available only after an accepted snapshotARIEC61850.lock.jsonis copied into build/publish output for offline provenanceFocused regression coverage
Final focused TRX: 6 executed / 6 passed
sourcePullRequestprovenance schema resolves engine PR 45Final automated validation at head
182b928437540ef28acd5958dfbc4ec917b62d73Generated candidate artifacts
ARSAS-win-x64ARSAS-1.6.19-win-x64-installerARSAS-test-evidenceARSAS-sv-evidence-test-resultsStacked PR boundary
This PR is based on
agent/p0-hardening-1-6-19/ PR #107 and contains only P1 changes relative to that base. The development candidate remains ARSAS 1.6.19; stable public release remains 1.6.18.PCAP replay, trusted ordered SCL semantic binding, reviewed scaling and controlled known-injection/live-MU acceptance remain outside this evidence-export tranche.