Fix IO List window binding crash and align launcher UX - #113
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5e07acc5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| var emptyState = workspace?.Children | ||
| .OfType<Border>() | ||
| .FirstOrDefault(border => | ||
| BindingOperations.GetBinding(border, UIElement.VisibilityProperty)?.Path?.Path == nameof(EmptyExplorerVisibility)); |
There was a problem hiding this comment.
Keep the FAT launcher accessible with a selected IED
When a loaded IED is selected—the state required for a runnable FAT session—this relocates the launcher into the border bound to EmptyExplorerVisibility, which is collapsed whenever SelectedDevice != null (MainWindow.xaml.cs:103). The only repo-wide registration of OpenIoListTesting_Click is the new button inside this card, while session startup requires the imported IED to already be loaded, connected, and monitoring, so the normal operational state now has no visible way to open IO List Testing.
Useful? React with 👍 / 👎.
Fixes
Run.Textbinding inIoListTestingWindowexplicitlyMode=OneWayEvidenceRecordCount, bound count, passed count, and pending count so the next get-only counter cannot trigger the same failureFirst-run workflow UX
Removes the injected IO List Testing button from the top status/header area and turns the empty Explorer hero into two clear workflow cards:
General IEC 61850 Testing
FAT / IO List Testing
At normal desktop width the cards appear side by side. The container wraps at narrower supported widths instead of overlapping.
Regression protection
IoListTestingWindow.xamland requires every boundRunto declareMode=OneWayScope
No changes to workbook import, IEC 61850 runtime, FAT state machine, or evidence journal semantics.