Keep manual release dispatches artifact-only#12
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b520b89078
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| release: | ||
| name: Publish GitHub Release | ||
| if: github.ref_type == 'tag' || startsWith(github.ref, 'refs/heads/release/v') | ||
| if: github.ref_type == 'tag' || (github.event_name == 'push' && startsWith(github.ref, 'refs/heads/release/v')) |
There was a problem hiding this comment.
For a workflow_dispatch run started against a tag ref, github.ref_type is still tag, so this condition still runs the public release job even though the change is meant to make manual dispatches artifact-only. In that same scenario the version step also resolves from the tag before checking workflow_dispatch, so a maintainer trying to produce a manual artifact from a tag can still publish or update the GitHub Release; require github.event_name == 'push' for the tag path as well.
Useful? React with 👍 / 👎.
1 participant
Follow-up hardening for the public release trigger.
workflow_dispatchalways honors its explicit version input.release/vX.Y.Zbranch publishes only when the event is an actualpush.Direct tag releases and versioned release-branch pushes remain unchanged.