DP-46079: Replace hardcoded hostname validations with a config-driven approach for Gravity Forms iframe rendering#3306
Merged
tfleming-ma merged 3 commits intodevelopfrom Apr 3, 2026
Conversation
… approach for Gravity Forms iframe rendering Refactored hostname validation logic across modules to use a single source of truth from `mass_utility.settings`. This ensures consistent handling of allowed hostnames, improving maintainability and resolving iframe rendering issues in non-production environments. Added changelog entry. Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
…ngs` configuration Introduced an update hook to define allowed hostnames for Gravity Forms in `mass_utility.settings`, ensuring configurability and consistent iframe rendering across environments. Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
Collaborator
|
@dstorozhuk Overall looks good. Only feedback I have is that I think I would call the setting |
Collaborator
Author
|
@tfleming-ma I think you missed the proposed name |
…names in mass_utility.settings and update related references
Collaborator
|
LGTM |
dstorozhuk
added a commit
that referenced
this pull request
Apr 3, 2026
…atables-accessibility * refs/heads/develop: (28 commits) DP-46079: Replace hardcoded hostname validations with a config-driven approach for Gravity Forms iframe rendering (#3306) DP-44741: Drupal 11.3 + modules and libraries update (#3250) DP-45713 Add-filter-to-advanced-search-for-pages_documents-to-allow-users-to-search-for-multiple-entity_media-IDs (#3300) changelog update and remove old changelog files Dp 45686 fix form validation errors auto announce jaws (#3293) DP-45780-News-Page-Related-Links-Not-Rendering-for-Certain-Announcement-Types (#3299) DP-45633: Update datatables libraries used with CSV tables module (#3288) Prevented empty contact email/online links from rendering and required the online email field in contact information (#3296) DP-45721: Added related service to news (#3291) DP-45201: service card changes (#3297) DP-45855: fix-footer-url (#3298) Fixed microsite routeMatch causing issues on microsite views changelog update and remove old changelog files DP-39488-Print-styles-batch-3 (#3154) DP-44787: footer iteration (#3265) DP-45783 Update-Accesibility-Status-to-excluded-TBD-on-all-content-type-with-document-attachment (#3292) DP-45720: remove-rich-text-limit-service-pg (#3284) DP-45679: disable-unused-infodetail-field (#3285) DP-45563: Update report showing docs without files (#3286) DP-45715: Edit page header problem on pages in microsite (#3287) ... # Conflicts: # composer.json # composer.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Explain the technical implementation of the work done.
Jira: (Skip unless you are MA staff)
DP-****
To Test:
Peer Review Checklist