chore: delete v1 distribution artifacts#51
Conversation
Remove the parallel v1 distribution channels as part of the v2 cutover: - plugins/wealthbox-crm/ (Claude Code plugin mirror) - codex-skill/wealthbox-crm/ (Codex skill mirror) - .claude-plugin/marketplace.json (custom marketplace listing) Also removed scripts/sync-plugin.py — its only purpose was syncing the canonical skill template at src/wealthbox_tools/skills/wealthbox-crm/ into the two mirror copies above. With both targets deleted the script has nothing left to do. The single source of truth at src/wealthbox_tools/skills/wealthbox-crm/ is untouched. The Anthropic-side marketplace listing is delisted manually on release day. Closes #27 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83248d60f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,25 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
Deleting the repository-level Claude marketplace file breaks the install path that is still advertised and executed elsewhere: README.md tells users to run /plugin marketplace add massive-value/wealthbox-cli, and both scripts/install.sh and scripts/install.ps1 still run claude plugin marketplace add massive-value/wealthbox-cli followed by claude plugin install wealthbox-crm@massive-value. With this file and plugins/wealthbox-crm/ removed, a fresh Claude Code user following the default installer can no longer resolve the wealthbox-crm@massive-value plugin.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Deferring per the one-round rule. The marketplace deletion is intentional v2 cutover scope (this PR closes #27); the README + install scripts pointing at the dropped marketplace path are tracked separately by #42 (install.sh rewrite to GitHub Releases), #43 (install.ps1 parity), and #55 (README rework). Once those land, the dangling references are gone. Coordination tracked under v2 cutover umbrella #50.
| @@ -1,160 +0,0 @@ | |||
| --- | |||
There was a problem hiding this comment.
The repo still contains .codex-plugin/plugin.json with "skills": "./codex-skill", but this deletion removes the only skill payload under that path. Any Codex plugin install/read of this manifest will point at a missing codex-skill directory, so the plugin metadata remains publishable-looking while containing no installable wealthbox-crm skill.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Deferring. Same v2 cutover coordination — the .codex-plugin/plugin.json reference is explicitly noted in the PR body as left-as-is (out of scope here). Cleanup of .codex-plugin/ will follow once we decide the v2 Codex story; opening a follow-up issue if it doesn't land in #50.
|
Holding this PR until #42 (install.sh rewrite) and #43 (install.ps1 parity) land. Codex flagged two valid P1s here:
Both are pure ordering issues — the deletion is correct for v2, but the v1 install flow needs to be replaced first. Once #42/#43 land (PyInstaller binaries + new install scripts) and the README rework (#55) is in, this can rebase and merge cleanly. The Codex p2 finding on PR #54 (`wbox doctor` no longer reports plugin-cache installs) is the same root cause — both should be merged together as part of the v2.0.0 cutover (#50). Tagging blockers via metadata. |
Follow-up to #27 / #50 — v2.0.0 cleanup audit found two leftovers. - Delete `.codex-plugin/plugin.json`. PR #51 (closing #27) explicitly punted on this manifest because "the issue scope is explicit and `.codex-plugin/` is not in the deletion list" — but its sibling artifacts (the Claude marketplace manifest and the `codex-skill/` mirror) were deleted, leaving this file with a broken `./codex-skill` pointer to a directory that no longer exists. Removing it makes the v2.0.0 changelog claim "Removed v1 distribution artifacts (#27)" fully accurate. - Consolidate the changelog. Migrate the v0.1–v1.3 history from `docs/changelog.md` into the root `CHANGELOG.md` (which previously held only the v2.0.0 entry), delete the docs copy, and drop the Changelog entry from `mkdocs.yml` nav. Single source of truth at the repo root, no duplication risk for future releases. `ruff check src/ tests/` clean. `pytest -q` 391 passed, 1 skipped. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 participant
Summary
Remove the parallel v1 distribution channels from the source tree as part of the v2 cutover. The single source-of-truth skill template at
src/wealthbox_tools/skills/wealthbox-crm/remains untouched; the Anthropic-side marketplace listing is delisted manually on release day.Deleted:
plugins/wealthbox-crm/(Claude Code plugin mirror)codex-skill/wealthbox-crm/(Codex skill mirror).claude-plugin/marketplace.json(custom marketplace listing)scripts/sync-plugin.py— incidental cleanup. Its only job was syncing the canonical skill template into the two mirrors above; with both targets gone, the script is dead code.Notes on incidental references
.codex-plugin/plugin.jsonstill has"skills": "./codex-skill"pointing at a now-deleted directory. Left as-is — the issue scope is explicit and.codex-plugin/is not in the deletion list.docs/changelog.mdv1.2.0 entries describe these artifacts. Left as-is — changelogs are historical records of what shipped, and rewriting them would falsify release history. They are descriptive prose, not active path references.Test plan
ruff check src/ tests/passes (All checks passed!)pytest -qpasses (272 passed)docs/changelog.md(historical) per aboveCloses #27
🤖 Generated with Claude Code