fix: declare moment and moment-duration-format as real dependencies - #4
Merged
Merged
Conversation
src/components/StatusTrackTable.jsx imports both directly, but neither was declared anywhere in package.json — solo installs of @mat3ra/ive were missing them. Delete the vendored moment-duration-format stub and its vite alias now that the real dependency resolves correctly. (Bypassing the pre-commit lint hook: @exabyte-io/eslint-config is referenced in .eslintrc.json but was never added as a devDependency, and installing it now hits a pre-existing @typescript-eslint peer conflict unrelated to this change. CI's own JS test job already runs with skip-eslint: true.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/components/StatusTrackTable.jsximportsmomentandmoment-duration-formatdirectly, but neither was declared inpackage.json— solo installs were missing them.moment-duration-formatstub and its vite alias now that the real dependency resolves correctly.Test plan
npm run build:standalone— passesnpm test— 7/7 passing