fix: run full build before npm publish (broken 2026.8.18-0 release) - #53
Merged
Conversation
The js/publish action never ran a build step - it relied entirely on dist/ already being committed to git. Since dist/ was gitignored in #52, `npm publish` on merge to main shipped an EMPTY dist/ - nothing in that CI job's steps (install, test) builds it. This already shipped a broken @mat3ra/utils@2026.8.18-0 to npm. Adding prepublishOnly (an npm lifecycle hook npm publish runs automatically) running the same transpile script already used and verified by release-wip.yml.
timurbazhirov
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same systemic issue as mat3ra/esse#421: `js/publish` never runs a build step, relying
entirely on `dist/` being committed to git. Since #52 gitignored `dist/`, the real
`npm publish` on merge to `main` shipped a completely empty `dist/` — nothing in
that job's steps (install, test) builds it. This already shipped a broken
@mat3ra/utils@2026.8.18-0 to npm.
Fix
Add `prepublishOnly` running the same `transpile` script already used and verified by
`release-wip.yml`. Verified locally: `rm -rf dist && npm run prepublishOnly` produces
the full, correct `dist/js/` tree.