feat: live refresh in the download/upload/task info modals#111
Merged
Conversation
The info modals held a live reference to their model but only rendered a snapshot taken when opened, so progress, state, duration and speed froze until the modal was reopened. Subscribe each modal to the aggregated throttled TransactionsChanged event while it is visible (subscribed on ShowModal, unsubscribed on HideModal and Dispose) and re-render on the UI thread, following the same pattern the transfer tables use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The info modals (DownloadFileInfoModal, UploadFileInfoModal, TaskInfoModal) hold a live reference to their model but only render the snapshot taken when opened: progress, state, transferred bytes, duration and average speed stay frozen until the modal is closed and reopened.
Changes
Each modal now subscribes to the aggregated, throttled
TransactionsChangedevent (introduced in #98) only while it is visible: subscribed inShowModal, unsubscribed inHideModalandDispose, re-rendering viaInvokeAsync(StateHasChanged)— the same pattern the transfer tables use. Since the model reference is live, a re-render is all that is needed; updates arrive at most every ~250ms thanks to the service-side throttle.This covers progress %, transferred/total bytes, state badge, duration, average speed and (in the task modal) the per-file counters, all updating in real time while the modal is open.