This repository was archived by the owner on Dec 11, 2025. It is now read-only.
[TextControls] Add Initial text area class #9684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR affects multiple components. |
andrewoverton
force-pushed
the
initial-text-area-class
branch
from
ba0b518 to
1aaf86c
Compare
codeman7
reviewed
Feb 11, 2020
codeman7
approved these changes
Feb 11, 2020
andrewoverton
added a commit
to andrewoverton/material-components-ios
that referenced
this pull request
Feb 13, 2020
This PR adds the MDCBaseTextArea that utilizes the text view added in material-components#9682. Note that it is being merged into a feature branch because of our current lack of CI. Once CI is back up and running I'll open a PR to merge the feature branch into develop. BUILD file and podspec changes to follow then. Related to #9407.
andrewoverton
added a commit
that referenced
this pull request
Feb 13, 2020
…podspec and BUILD file changes (#9711) Because CI wasn't working earlier this week I merged the initial text area PRs (#9682 and #9684) into a [feature branch](https://github.com/material-components/material-components-ios/tree/text-area-feature-branch) in the main repo. This PR contains those changes, as well as a commit to update the BUILD file and podspec (3da2803), a commit that makes it compile (6a06594), and a commit to run clang (078cd70). The changes in these last three commits have not been reviewed, unlike the ones from the PRs into the feature branch. Related to #9407.
yarneo
pushed a commit
that referenced
this pull request
Feb 19, 2020
…podspec and BUILD file changes (#9711) Because CI wasn't working earlier this week I merged the initial text area PRs (#9682 and #9684) into a [feature branch](https://github.com/material-components/material-components-ios/tree/text-area-feature-branch) in the main repo. This PR contains those changes, as well as a commit to update the BUILD file and podspec (3da2803), a commit that makes it compile (6a06594), and a commit to run clang (078cd70). The changes in these last three commits have not been reviewed, unlike the ones from the PRs into the feature branch. Related to #9407.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the MDCBaseTextArea that utilizes the text view added in #9682.
Note that it is being merged into a feature branch because of our current lack of CI.
Once CI is back up and running I'll open a PR to merge the feature branch into develop.
BUILD file and podspec changes to follow then.
Related to #9407.