datacite minting fixes#112
Merged
BenGalewsky merged 18 commits intodevfrom Feb 12, 2024
Merged
Conversation
submissions separate from prod when testing for duplicate source IDs
Send email to admin when a new submission is received
The first time I did this, I had neglected to add the client ID to the "Globus Flows Users" group. This meant that the flow was marked as expired after a few weeks. Accepted an invition to join the group and recreated the flow
Complete settings for new flow ID
Limit submissions to users who are members of Globus Group
Pretty Submission Report Email and Fix Exception Handling
Make dyanamo table read capacity a variable
Remove greeting in success email
Include original submission in status response
Include version in the Portal link Throw proper exception on invalid organization
BenGalewsky
requested changes
Feb 12, 2024
Contributor
BenGalewsky
left a comment
BenGalewsky
left a comment
There was a problem hiding this comment.
I think my understanding of the DataCite AP is correct, but please double check
| "publicationYear.$": "$.dataset_mdata.dc.publicationYear", | ||
| "url.$": "$.mdf_portal_link", | ||
| }, | ||
| "event": "publish", |
Contributor
There was a problem hiding this comment.
I think these need to go up in the attributes section, and not in the Doi parent?
Contributor
Author
|
Ok, I have made the requested changed @BenGalewsky. Thanks for catching that. |
BenGalewsky
approved these changes
Feb 12, 2024
Contributor
BenGalewsky
left a comment
BenGalewsky
left a comment
There was a problem hiding this comment.
Great - let's try this out
BenGalewsky
added a commit
that referenced
this pull request
Feb 12, 2024
datacite minting fixes (#112)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"event": "publish"to mint the DOI directly instead cofminting a draft DOI