fix: stable topbar across languages, mobile layout, localized tab title#11
Merged
Conversation
- Auth buttons reserve their longest translation via ch minimums, and the controls block is pinned right, so switching language no longer shrinks/expands the bar (es labels previously overflowed the fixed 260px column and blew the grid) - Mobile: compact single-button language cycler, icon brand, tighter paddings, login moves behind the register CTA; no overflow at 360px - Tab title, meta description, and html lang now follow the active language (en, pt-BR, es) via an i18next languageChanged listener
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on the UI feedback: the topbar visibly shrank/expanded when switching language, broke on mobile, and the new tab title was fixed in English despite the app shipping en/pt-BR/es.
Changes made
Test plan