This repository was archived by the owner on Apr 6, 2024. It is now read-only.
Features/script manager - #4
Closed
matglas wants to merge 33 commits into
Closed
Conversation
Moved classes around Added config to js. Changed js load handling. Prepared ajax handling. Removed class includes. Tested addthis.js include through attached.
Owner
Author
There was a problem hiding this comment.
I don't know if the test pages that I build should be here or in another addthis_test module. Suggestions?
Owner
Author
|
Here is the ticket on D.O. https://www.drupal.org/node/2333231. |
There was a problem hiding this comment.
What if the addthis buttons are in new ajax content?
Owner
Author
|
Anyone wants to review again? |
Owner
Author
|
Commited on drupal.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a addition to handle the inclusion of js script better. Using attached in the end means handling caching better.
It also restructures some test classes and creates new test classes.